Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all microservices to Symfony #133

Merged
merged 19 commits into from
Sep 16, 2022
Merged

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Nov 3, 2021

GitHub Issue: Islandora/documentation#1224

What does this Pull Request do?

Replaces the deprecated Silex framework with Symfony 4.4 (LTS) for all the other microservices (Houdini which was 4.3 is also now 4.4)

This PR relies on Islandora/Crayfish-Commons#49

As this is not backwards compatible with Crayfish 2.0.0 this PR is against the new 3.x branch and will be the first commit for version 3.0.0 of Crayfish

I'm making this a draft PR as there are still README changes to come also it will need the Crayfish-Commons PR merged and a release cut so this PR can be updated to reference the correct semantic version.

EDIT: Readme changes added, the readmes were very out-of-date.

What's new?

This should have no functional effect on the microservices.

How should this be tested?

Pull this branch in to your setup and install it. You will need to migrate your various settings.

There is an islandora-playbook draft PR to setup using this PR here:
Islandora-Devops/islandora-playbook#207

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers

@whikloj
Copy link
Member Author

whikloj commented Nov 4, 2021

Quick question, I did not add the WebServerBundle to all the microservices so you can't easily run a test instance of a microservice. Does anyone use that regularly with Silex and want it as an option?

@whikloj
Copy link
Member Author

whikloj commented Dec 1, 2021

Added upgrade instructions to each individual service for moving configuration from version 2.x to 3.0.0

Copy link
Contributor

@adam-vessey adam-vessey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various comments:

  • Some misc inconsistencies in dependencies/lock files (symfony.lock? Not sure if/how its actually used...)
  • bin/console stuff... is it actually necessary? Not seeing any reference to it in any of the readmes... I guess the composer.json thing has a couple calls using it?

Homarus/UPGRADE.md Outdated Show resolved Hide resolved
Homarus/src/Controller/HomarusController.php Outdated Show resolved Hide resolved
Houdini/public/index.php Show resolved Hide resolved
Homarus/bin/console Outdated Show resolved Hide resolved
Homarus/composer.json Outdated Show resolved Hide resolved
Milliner/config/packages/prod/deprecations.yaml Outdated Show resolved Hide resolved
Hypercube/symfony.lock Outdated Show resolved Hide resolved
Homarus/symfony.lock Outdated Show resolved Hide resolved
Houdini/static/identify.ttl Show resolved Hide resolved
Houdini/static/convert.ttl Show resolved Hide resolved
@whikloj whikloj marked this pull request as ready for review May 5, 2022 16:05
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Base: 76.74% // Head: 76.56% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (1f0a732) compared to base (09a62a4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.x     #133      +/-   ##
============================================
- Coverage     76.74%   76.56%   -0.19%     
+ Complexity      161      155       -6     
============================================
  Files             6        6              
  Lines           658      576      -82     
============================================
- Hits            505      441      -64     
+ Misses          153      135      -18     
Impacted Files Coverage Δ
...ild_dir/Recast/src/Controller/RecastController.php 53.62% <0.00%> (-1.58%) ⬇️
...dir/Milliner/src/Controller/MillinerController.php 95.06% <0.00%> (-0.35%) ⬇️
...d_dir/Homarus/src/Controller/HomarusController.php 100.00% <0.00%> (ø)
...d_dir/Houdini/src/Controller/HoudiniController.php 100.00% <0.00%> (ø)
...r/Hypercube/src/Controller/HypercubeController.php 100.00% <0.00%> (ø)
build_dir/Milliner/src/Service/MillinerService.php 71.24% <0.00%> (+0.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@whikloj
Copy link
Member Author

whikloj commented May 5, 2022

I updated Islandora-Devops/islandora-playbook#207 so it would still build with the this PR if you want to try it out.

Copy link
Member

@ruebot ruebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this in my dev/stage/prod builds for a few months now, and everything seems fine. Set it all up in conjunction with your Alpaca 2.0.0 work.

@whikloj
Copy link
Member Author

whikloj commented Sep 12, 2022

@Islandora/committers bump

Houdini/README.md Outdated Show resolved Hide resolved
@seth-shaw-asu seth-shaw-asu merged commit 82320e5 into Islandora:3.x Sep 16, 2022
@whikloj
Copy link
Member Author

whikloj commented Sep 16, 2022

Thank you @seth-shaw-asu 🙇

@whikloj whikloj deleted the issue-1224 branch September 16, 2022 18:05
ruebot added a commit to yorkulibraries/yudl-playbook that referenced this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants