-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all microservices to Symfony #133
Conversation
Quick question, I did not add the WebServerBundle to all the microservices so you can't easily run a test instance of a microservice. Does anyone use that regularly with Silex and want it as an option? |
Added upgrade instructions to each individual service for moving configuration from version 2.x to 3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Various comments:
- Some misc inconsistencies in dependencies/lock files (
symfony.lock
? Not sure if/how its actually used...) bin/console
stuff... is it actually necessary? Not seeing any reference to it in any of the readmes... I guess thecomposer.json
thing has a couple calls using it?
Codecov ReportBase: 76.74% // Head: 76.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## 3.x #133 +/- ##
============================================
- Coverage 76.74% 76.56% -0.19%
+ Complexity 161 155 -6
============================================
Files 6 6
Lines 658 576 -82
============================================
- Hits 505 441 -64
+ Misses 153 135 -18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I updated Islandora-Devops/islandora-playbook#207 so it would still build with the this PR if you want to try it out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using this in my dev/stage/prod builds for a few months now, and everything seems fine. Set it all up in conjunction with your Alpaca 2.0.0 work.
@Islandora/committers bump |
Thank you @seth-shaw-asu 🙇 |
- Islandora/Crayfish#133 was merged!
GitHub Issue: Islandora/documentation#1224
What does this Pull Request do?
Replaces the deprecated Silex framework with Symfony 4.4 (LTS) for all the other microservices (Houdini which was 4.3 is also now 4.4)
This PR relies on Islandora/Crayfish-Commons#49
As this is not backwards compatible with Crayfish 2.0.0 this PR is against the new
3.x
branch and will be the first commit for version3.0.0
of CrayfishI'm making this a draft PR as
there are still README changes to come alsoit will need the Crayfish-Commons PR merged and a release cut so this PR can be updated to reference the correct semantic version.EDIT: Readme changes added, the readmes were very out-of-date.
What's new?
This should have no functional effect on the microservices.
How should this be tested?
Pull this branch in to your setup and install it. You will need to migrate your various settings.
There is an islandora-playbook draft PR to setup using this PR here:
Islandora-Devops/islandora-playbook#207
Interested parties
Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers