Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add core image server settings #725

Open
wants to merge 7 commits into
base: 7.x
Choose a base branch
from
Open

Add core image server settings #725

wants to merge 7 commits into from

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Aug 26, 2019

JIRA Ticket: https://jira.duraspace.org/browse/ISLANDORA-2469

Related PRs:

What does this Pull Request do?

Creates a new configuration space in core for image server settings. This will be shared between Paged Content, the IABV and Openseadragon.

What's new?

An admin form, tokens and some helper functions.

How should this be tested?

Try setting as type as none, Djatoka and IIIF, ensure the form saves your settings. Set using different tokens for IIIF, etc. If you have a custom setup for your site, try it here and ensure it is still supported.

Additional Notes:

Example:

  • Does this change the interface, add a new feature, or otherwise change behaviours that would require updating documentation? Yes, documentation changes could be needed in the wiki. I have altered the old configuration forms to direct people here to configure their image server.
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? It will if settings are not auto-configured until someone fixes them.

Interested parties

@Islandora/7-x-1-x-committers @jonathangreen

Fix update hook, change imageserver filename
includes/imageserver.inc Outdated Show resolved Hide resolved
includes/imageserver.inc Outdated Show resolved Hide resolved
includes/imageserver.inc Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
includes/imageserver.inc Outdated Show resolved Hide resolved
includes/imageserver.inc Outdated Show resolved Hide resolved
islandora.install Outdated Show resolved Hide resolved
islandora.install Outdated Show resolved Hide resolved
@whikloj
Copy link
Member Author

whikloj commented Aug 28, 2019

All good suggestions, thanks @adam-vessey. Updates coming.

README.md Outdated Show resolved Hide resolved
includes/imageserver.inc Outdated Show resolved Hide resolved
includes/imageserver.inc Outdated Show resolved Hide resolved
includes/imageserver.inc Outdated Show resolved Hide resolved
includes/imageserver.inc Outdated Show resolved Hide resolved
islandora.install Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants