Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Points of interest to use tiles #1979

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Move Points of interest to use tiles #1979

wants to merge 9 commits into from

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Mar 22, 2024

Fixes #1971

This change the following:

  1. It takes the POIs from a tile source and not from the server's database
  2. It downloads an offline file to allow seeing the POIs when offline - assuming we use the current offline model - i.e. only paying customers will have offline POIs
  3. Offline search is removed at this point in time

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 35.82090% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 90.17%. Comparing base (7f0615d) to head (47b970c).
Report is 2 commits behind head on main.

Files Patch % Lines
...Hiking.Web/src/application/services/poi.service.ts 34.61% 81 Missing and 4 partials ⚠️
...rc/application/services/search-results.provider.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1979      +/-   ##
==========================================
- Coverage   91.01%   90.17%   -0.84%     
==========================================
  Files          93       93              
  Lines        6820     6800      -20     
  Branches      982      978       -4     
==========================================
- Hits         6207     6132      -75     
- Misses        411      464      +53     
- Partials      202      204       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleted POI is not in database
2 participants