Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ—Ί Migrate To New Nexus Prisma Plugin #756

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

robin-macpherson
Copy link
Contributor

@robin-macpherson robin-macpherson commented Jan 1, 2022

Description

Issue:

This started out as an experimental PR to explore the possibility of migrating off of nexus-plugin-prisma to the new nexus-prisma plugin and understand the new API and the risks/complexity of migrating.

After initial exploration and discussion, we decided to move forward with the migration which is now the purpose of this PR.

Subtasks 1 (Research Phase)

  • I have added this PR to the Journaly Kanban project βœ…
  • Handle installation and at least get things generating
  • Start converting a few things and see how easy it is, how well documented things are, and find any possible questions that need clarifying
  • Discuss and see whether or not to continue

Subtasks 2 (Execution Phase)

  • Add documentation to schema
  • Re-order schema so that the ordering is a bit more logical
  • Get things at least building with nexus-prisma
  • Convert everything over to the new syntax at a high level and find any blockers
  • Complete the initial refactor and get the build functioning
  • FInalize schema changes and publish new j-db-client version to NPM
  • Finalize refactor and get build completely passing finally
  • Figure out most thorough code review and testing strategy
  • Test, test, test, and then test some more
  • A bit more testing
  • Test one more time.

Deployment Checklist

  • 🚨 Publish new j-db-client version and update in both web and j-mail
  • 🚨 Deploy migs to stage
  • 🚨 Deploy code to stage
  • 🚨 DEPLOY j-mail to stage
  • 🚨 Deploy migs to prod
  • 🚨 Deploy code to prod
  • 🚨 DEPLOY j-mail TO PROD

Migrations

If your PR doesn't involve any changes to the database, you can delete this section. If it does, briefly describe how it needs to be applied. Some common things you might mention are:

  • Does the migration need to be applied before or after deploying code?
  • Is applying the migration going to necessitate downtime?
  • Is there any SQL or backfill logic that has to be run manually?
  • Are the DB changes high risk in your estimation? Should a manual DB snapshot be taken before applying?

Screenshots

@vercel
Copy link

vercel bot commented Jan 1, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/journaly/journaly/4DxHhGzUTX1aB3uZtfSJaueRnXCQ
βœ… Preview: https://journaly-git-migrate-to-nexus-prisma-plugin-journaly.vercel.app

@robin-macpherson robin-macpherson self-assigned this Jan 1, 2022
@robin-macpherson robin-macpherson added dependencies Pull requests that update a dependency file refactor requires migration labels Jan 1, 2022
@robin-macpherson robin-macpherson added this to In progress in Master Board via automation Jan 1, 2022
@robin-macpherson robin-macpherson moved this from To do to In progress in πŸ— Infra Board Jan 13, 2022
@robin-macpherson robin-macpherson removed this from In progress in πŸ— Infra Board Jan 13, 2022
@robin-macpherson robin-macpherson changed the title Proposal: Migrate To New Nexus Prisma Plugin πŸ“œ Proposal: Migrate To New Nexus Prisma Plugin Jan 17, 2022
@robin-macpherson robin-macpherson changed the title πŸ“œ Proposal: Migrate To New Nexus Prisma Plugin πŸ—Ί Migrate To New Nexus Prisma Plugin Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file refactor requires migration
Projects
Master Board
  
In progress
Development

Successfully merging this pull request may close these issues.

πŸ—Ί Migrate To Nexus-Prisma Plugin
1 participant