#711 Don't Allow Empty Comments #790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Demezis is attempting to deploy a commit to the Journaly Team on Vercel. A member of the Team first needs to authorize it. |
robin-macpherson
requested changes
Jul 5, 2022
There was a problem hiding this comment.
Thanks a lot for this PR @Demezis , it's great to see you contributing again! We're using a ref to track the comment body state for performance reasons and I think the refactor there is not worth the trade-off. To be honest I think for this we can just return early/do nothing if someone attempts to submit a comment and the ref value is empty.
robin-macpherson
modified the milestones:
🧘🏻♂️ Journaly Stable Release 🙌🏼,
🥍 Bug Hunting Season 🐞 Q1 2022
|
I have reverted changes regarding threads, and now it should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: #711 Don't Allow Empty Comments
Subtasks
Deployment Checklist
Screenshots