Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Next.js to 13.5.6 #881

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

robin-macpherson
Copy link
Contributor

@robin-macpherson robin-macpherson commented Dec 18, 2023

Description

Based on security advisories.

Subtasks

  • I have added this PR to the Journaly Kanban project βœ…
  • Make the upgrade
  • Test and see if anything breaks
  • Figure out NextRouter issue (see comments)

Deployment Checklist

  • 🚨 Publish new j-db-client version and update in both web and j-mail
  • 🚨 Deploy migs to stage
  • 🚨 Deploy code to stage
  • 🚨 DEPLOY j-mail to stage
  • 🚨 Deploy migs to prod
  • 🚨 Deploy code to prod
  • 🚨 DEPLOY j-mail TO PROD

Migrations

If your PR doesn't involve any changes to the database, you can delete this section. If it does, briefly describe how it needs to be applied. Some common things you might mention are:

  • Does the migration need to be applied before or after deploying code?
  • Is applying the migration going to necessitate downtime?
  • Is there any SQL or backfill logic that has to be run manually?
  • Are the DB changes high risk in your estimation? Should a manual DB snapshot be taken before applying?

Screenshots

Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
journaly βœ… Ready (Inspect) Visit Preview Dec 18, 2023 3:36am

@robin-macpherson robin-macpherson self-assigned this Dec 18, 2023
@robin-macpherson robin-macpherson added upgrades dependencies Pull requests that update a dependency file labels Dec 18, 2023
@robin-macpherson robin-macpherson added this to In progress in Master Board via automation Dec 18, 2023
@robin-macpherson
Copy link
Contributor Author

robin-macpherson commented Dec 18, 2023

Upon starting dev server got the following error:
Terminal

Error while running `getDataFromTree` Error: NextRouter was not mounted. https://nextjs.org/docs/messages/next-router-not-mounted

Browser console

Uncaught Error: NextRouter was not mounted. https://nextjs.org/docs/messages/next-router-not-mounted
    at useRouter (/Users/robin/projects/journaly/packages/web/node_modules/next/dist/client/router.js:146:15)
    at WithRouterWrapper (/Users/robin/projects/journaly/packages/web/node_modules/next/dist/client/with-router.js:17:43)
    at renderWithHooks (/Users/robin/projects/journaly/packages/web/node_modules/react-dom/cjs/react-dom-server.browser.development.js:5658:16)
    at renderIndeterminateComponent (/Users/robin/projects/journaly/packages/web/node_modules/react-dom/cjs/react-dom-server.browser.development.js:5731:15)
    at renderElement (/Users/robin/projects/journaly/packages/web/node_modules/react-dom/cjs/react-dom-server.browser.development.js:5946:7)
    at renderNodeDestructiveImpl (/Users/robin/projects/journaly/packages/web/node_modules/react-dom/cjs/react-dom-server.browser.development.js:6104:11)
    at renderNodeDestructive (/Users/robin/projects/journaly/packages/web/node_modules/react-dom/cjs/react-dom-server.browser.development.js:6076:14)
    at renderIndeterminateComponent (/Users/robin/projects/journaly/packages/web/node_modules/react-dom/cjs/react-dom-server.browser.development.js:5785:7)
    at renderElement (/Users/robin/projects/journaly/packages/web/node_modules/react-dom/cjs/react-dom-server.browser.development.js:5946:7)
    at renderNodeDestructiveImpl (/Users/robin/projects/journaly/packages/web/node_modules/react-dom/cjs/react-dom-server.browser.development.js:6104:11)
    at renderNodeDestructive (/Users/robin/projects/journaly/packages/web/node_modules/react-dom/cjs/react-dom-server.browser.development.js:6076:14)
    at renderNode (/Users/robin/projects/journaly/packages/web/node_modules/react-dom/cjs/react-dom-server.browser.development.js:6259:12)
    at renderChildrenArray (/Users/robin/projects/journaly/packages/web/node_modules/react-dom/cjs/react-dom-server.browser.development.js:6211:7)
    at renderNodeDestructiveImpl (/Users/robin/projects/journaly/packages/web/node_modules/react-dom/cjs/react-dom-server.browser.development.js:6141:7)
    at renderNodeDestructive (/Users/robin/projects/journaly/packages/web/node_modules/react-dom/cjs/react-dom-server.browser.development.js:6076:14)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file upgrades
Projects
Master Board
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant