Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Some New Testing Infrastructure For Future Improvements To Highlight Repositioning Algo #889

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Some New Testing Infrastructure For Future Improvements To Highlight Repositioning Algo #889

wants to merge 3 commits into from

Conversation

robin-macpherson
Copy link
Contributor

@robin-macpherson robin-macpherson commented Apr 25, 2024 •
edited

Description

Issue: #833

  • Continues our little refactor to split out our util code into more specific files, in this case our slate utils.
  • Adds some additional testing infra.
    • We were trying to fix or at least improve the current behavior when a highlight is very short, but this will require a pretty big effort. We at least documented the approach we'd like to take and added this extra testing infra to come back to this later.

@vercel Vercel
Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
journaly ✅ Ready (Inspect) Visit Preview Apr 25, 2024 3:45pm

@robin-macpherson robin-macpherson added this to In progress in Master Board via automation Apr 25, 2024
@robin-macpherson robin-macpherson added this to In progress in 🏗 Infra Board via automation Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lanny Lanny Awaiting requested review from Lanny

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
inline feedback experience refactor test Tests (thank you!)
Projects
Master Board
  
In progress
🏗 Infra Board
In progress
Milestone
🧘🏻‍♂️ Journaly Stable Release 🙌🏼
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@robin-macpherson