Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigen for FillArrays #330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Eigen for FillArrays #330

wants to merge 1 commit into from

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 22, 2023

Rebase #256 with only the FillArray part implemented this time. This makes eigvals O(1) and eigen O(N^2)

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7c34aa) 99.89% compared to head (42f7c9d) 99.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #330   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files           8        8           
  Lines         920      944   +24     
=======================================
+ Hits          919      943   +24     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty
Copy link
Member

This (and other parts that depend on LinearAlgebra.jl) should probably be an extension? Though I guess that can wait

@jishnub
Copy link
Member Author

jishnub commented Jan 4, 2024

Yes, we should move these to an extension eventually. Presumably, LinearAlgebra will be excised in Julia v1.11, so we should do it in the next few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants