Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from DataStreams to Tables #51

Merged
merged 5 commits into from
Oct 8, 2019

Conversation

ExpandingMan
Copy link
Collaborator

This is a duplicate of #46. I have made several fixes so that tests now pass and updated Travis and Appveyor. Making a new PR was just easier than me figuring out how to update the existing one.

Thanks again to @quinnj for having made this. I think the only reason it got ignored so long was because JavaCall was not working until 1.3.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@fe072f6). Click here to learn what that means.
The diff coverage is 64.28%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #51   +/-   ##
=========================================
  Coverage          ?   69.07%           
=========================================
  Files             ?        3           
  Lines             ?      152           
  Branches          ?        0           
=========================================
  Hits              ?      105           
  Misses            ?       47           
  Partials          ?        0
Impacted Files Coverage Δ
src/JDBC.jl 70% <ø> (ø)
src/tables.jl 74.28% <64.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe072f6...28cb829. Read the comment docs.

@ExpandingMan
Copy link
Collaborator Author

Suggest we merge and tag this quite quickly as the package is essentially broken without it.

Will do this myself tomorrow unless there are any concerns.

@aviks aviks merged commit b128b9a into JuliaDatabases:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants