Tone down admonition coloring #2499
Conversation
fredrikekre
force-pushed
the
fe/scratch-some-paint-from-admonitions
branch
2 times, most recently
from
c17886f
to
1ffec1e
Compare
fredrikekre
force-pushed
the
fe/scratch-some-paint-from-admonitions
branch
from
1ffec1e
to
13a92ea
Compare
|
Increased the border thickness a bit too since otherwise it was a bit difficult to see the color of the borders. I am happy with this now. |
|
LGTM! Yea, I think this will make them a bit easier to use, especially if you want to use more than one. The current ones a very eye-catching. For consistency, should we increase the thickness of the docstrings blocks and pre blocks maybe?
|
|
Maybe? And also round the corners like admonitions then? |
Actually, scratch that. I tested it a bit, and I actually like it better when docstrings and code blocks are rounded. So if you feel like it's worth making the change, let's go with that?
|
fredrikekre
force-pushed
the
fe/scratch-some-paint-from-admonitions
branch
from
13a92ea
to
06f9ad1
Compare
|
Updated, and also the |
Maybe this isn't needed actually? |
Do you mean getting rid of the border altogether or keeping it
|
I mean that increasing it isn't needed and agree that 1px looks nicer. |
This patch tones down the admonitions by removing the background color in the admonition header and the lighter background color in the body. Instead the text in the admonition header is colored, and the colored border thickness increased slightly. The border width of code blocks and docstrings have been increased to match the new border width of admonitions. Code blocks and docstrings now also have a (non-zero) border radius to match admonitions (which already were rounded before this patch).
fredrikekre
force-pushed
the
fe/scratch-some-paint-from-admonitions
branch
from
06f9ad1
to
b763bfe
Compare
|
I could finish up #2496 before, but doesn't really matter. |
|
Happy to hold off until then. The two changes go together nicely. |
This patch tones down the admonitions by removing the background color in the admonition header and the lighter color in the body. Instead the admonition header text is colored.