Avoid using String
constructor on Vector{UInt8}
#52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
String
constructor doesn't behave consistently for allAbstractVector{UInt8}
. Normally it makes a copy, except forVector{UInt8}
where it truncates the input. In Julia this can in some weird cases lead to undefined behavior. Ref: JuliaLang/julia#54372 JuliaLang/julia#54424This PR avoids potential issues with
String(v::Vector{UInt8})
by using an internalcopy_string(v::AbstractVector{UInt8})
function that should always make a copy of the input.