Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo rand methods #459

Open
tkoolen opened this issue Jul 11, 2018 · 0 comments
Open

Redo rand methods #459

tkoolen opened this issue Jul 11, 2018 · 0 comments

Comments

@tkoolen
Copy link
Collaborator

tkoolen commented Jul 11, 2018

  • rand methods should take an rng
  • perhaps use the new sampler machinery to change rand(Wrench{Float64}, frame) to rand(WrenchSampler(frame, [numbersampler]))
tkoolen added a commit that referenced this issue Aug 13, 2018
@tkoolen
Fix random seeds for tests.
1d0e5d7 
Should have done this a long time ago. Makes it easier to debug test failures on CI like the one in #475. Should really not be using the global RNG anyway, but requires a fix for #459. Use different seeds between test sets to avoid testing the same mechanism in all tests.
@tkoolen tkoolen mentioned this issue Aug 13, 2018
Merged
@tkoolen tkoolen mentioned this issue Sep 28, 2018
Merged
tkoolen added a commit that referenced this issue Nov 20, 2018
@tkoolen
Undo change to revolute joint rand_configuration distribution.
b3593fa 
Probably too many things tacitly assume this distribution at some point.

Should revisit as part of #459, but we shouldn't introduce backwards
incompatible changes right now.
@tkoolen tkoolen mentioned this issue Nov 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tkoolen