0006012: Prevented SymmetricDS from using 'create or alter' syntax on…

… SQL Server 2016 RTM
JumpMind · Oct 9, 2023 · 131227a · 131227a
1 parent 863d166
commit 131227a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/symmetric-core/src/main/resources/symmetric-default.properties b/symmetric-core/src/main/resources/symmetric-default.properties
@@ -2329,7 +2329,7 @@ trigger.capture.ddl.delimiter=$
 # Type: boolean
 trigger.capture.ddl.check.trigger.hist=true
 
-# Enable or disabled use of create or replace syntax on Oracle and MS-SQL 2016 and newer.
+# Enable or disabled use of create or replace syntax on Oracle and MS-SQL 2016 SP1 and newer.
 #
 # DatabaseOverridable: true
 # Tags: other

diff --git a/symmetric-jdbc/src/main/java/org/jumpmind/db/platform/mssql/MsSql2016DatabasePlatform.java b/symmetric-jdbc/src/main/java/org/jumpmind/db/platform/mssql/MsSql2016DatabasePlatform.java
@@ -28,11 +28,24 @@
 
 public class MsSql2016DatabasePlatform extends MsSql2008DatabasePlatform {
     public static final String JDBC_SUBPROTOCOL = "sqlserver";
+    public static final int SP1_BUILD_NUMBER = 4001;
 
     public MsSql2016DatabasePlatform(DataSource dataSource, SqlTemplateSettings settings) {
         super(dataSource, settings);
         if (settings.isAllowTriggerCreateOrReplace()) {
-            getDatabaseInfo().setTriggersCreateOrReplaceSupported(true);
+            boolean triggersCreateOrReplaceSupported = true;
+            String versionString = sqlTemplateDirty.queryForString("select serverproperty('ProductVersion')", (Object[]) null);
+            if (versionString != null) {
+                String[] versionArray = versionString.split("[.]");
+                if (versionArray.length == 4) {
+                    int majorVersion = Integer.parseInt(versionArray[0]);
+                    if (majorVersion == 13) {
+                        int buildNumber = Integer.parseInt(versionArray[2]);
+                        triggersCreateOrReplaceSupported = (buildNumber >= SP1_BUILD_NUMBER);
+                    }
+                }
+            }
+            getDatabaseInfo().setTriggersCreateOrReplaceSupported(triggersCreateOrReplaceSupported);
         }
     }