0003900: Improve performance of Oracle RAC routing processing

JumpMind · Apr 4, 2019 · 2139c4d · 2139c4d
1 parent 1d2d96b
commit 2139c4d
Showing 1 changed file with 20 additions and 6 deletions.
diff --git a/symmetric-core/src/main/java/org/jumpmind/symmetric/route/DataGapRouteReader.java b/symmetric-core/src/main/java/org/jumpmind/symmetric/route/DataGapRouteReader.java
@@ -274,12 +274,7 @@ protected boolean process(Data data) {
                 if (isEachGapQueried) {
                     okToProcess = true;
                 } else {
-                    for (DataGap gap : dataGaps) {
-                        if (dataId >= gap.getStartId() && dataId <= gap.getEndId()) {
-                            okToProcess = true;
-                            break;
-                        }
-                    }
+                    okToProcess = isInDataGap(dataId);
                 }
             } else {
                 while (!okToProcess && currentGap != null && dataId >= currentGap.getStartId()) {
@@ -298,6 +293,25 @@ protected boolean process(Data data) {
         }
         return okToProcess;
     }
+
+    protected boolean isInDataGap(long dataId) {
+        // binary search algorithm
+        int start = 0;
+        int end = dataGaps.size() - 1;
+        while (start <= end) {
+            int mid = (start + end) / 2;
+            DataGap midGap = dataGaps.get(mid);
+            if (dataId >= midGap.getStartId() && dataId <= midGap.getEndId()) {
+                return true;
+            }
+            if (dataId< midGap.getStartId()) {
+                end = mid - 1;
+            } else {
+                start = mid + 1;
+            }
+        }
+        return false;
+    }    
 
     public Data take() throws InterruptedException {
         Data data = null;