0004289: Oracle: rebuilding triggers can result in changed data not

being captured
JumpMind · Apr 10, 2020 · 233c2ec · 233c2ec
1 parent a6cbe44
commit 233c2ec
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 6 deletions.
diff --git a/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/TriggerRouterService.java b/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/TriggerRouterService.java
@@ -1868,11 +1868,14 @@ protected TriggerHistory rebuildTriggerIfNecessary(StringBuilder sqlBuffer,
             transaction = sqlTemplate.startSqlTransaction(platform.getDatabaseInfo().isRequiresAutoCommitForDdl());
 
             if ((forceRebuild || !triggerIsActive) && triggerExists) {
-                symmetricDialect.removeTrigger(sqlBuffer, oldCatalogName, oldSourceSchema,
-                        oldTriggerName, trigger.isSourceTableNameWildCarded() ? table.getName()
-                                : trigger.getSourceTableNameUnescaped(), transaction);
+                if (!triggerIsActive || !platform.getDatabaseInfo().isTriggersCreateOrReplaceSupported() ||
+                        !oldTriggerName.equalsIgnoreCase(newTriggerHist.getTriggerNameForDmlType(dmlType))) {
+                    symmetricDialect.removeTrigger(sqlBuffer, oldCatalogName, oldSourceSchema,
+                            oldTriggerName, trigger.isSourceTableNameWildCarded() ? table.getName()
+                                    : trigger.getSourceTableNameUnescaped(), transaction);
+                    triggerRemoved = true;
+                }
                 triggerExists = false;
-                triggerRemoved = true;
             }
 
             boolean isDeadTrigger = !trigger.isSyncOnInsert() && !trigger.isSyncOnUpdate() && !trigger.isSyncOnDelete();

diff --git a/symmetric-db/src/main/java/org/jumpmind/db/platform/DatabaseInfo.java b/symmetric-db/src/main/java/org/jumpmind/db/platform/DatabaseInfo.java
@@ -85,6 +85,8 @@ public class DatabaseInfo {
     private boolean uniqueEmbedded = true;
 
     private boolean triggersSupported = true;
+
+    private boolean triggersCreateOrReplaceSupported = false;
 
     /** Whether identity specification is supported for non-primary key columns. */
     private boolean nonPKIdentityColumnsSupported = true;
@@ -1366,5 +1368,13 @@ public boolean isZeroDateAllowed() {
     public void setZeroDateAllowed(boolean zeroDateAllowed) {
         this.zeroDateAllowed = zeroDateAllowed;
     }
-
+
+    public boolean isTriggersCreateOrReplaceSupported() {
+        return triggersCreateOrReplaceSupported;
+    }
+
+    public void setTriggersCreateOrReplaceSupported(boolean triggersCreateOrReplaceSupported) {
+        this.triggersCreateOrReplaceSupported = triggersCreateOrReplaceSupported;
+    }
+
 }
diff --git a/symmetric-db/src/main/java/org/jumpmind/db/platform/oracle/OracleDdlBuilder.java b/symmetric-db/src/main/java/org/jumpmind/db/platform/oracle/OracleDdlBuilder.java
@@ -108,7 +108,7 @@ public OracleDdlBuilder() {
         databaseInfo.setBlankCharColumnSpacePadded(true);
         databaseInfo.setCharColumnSpaceTrimmed(false);
         databaseInfo.setEmptyStringNulled(true);
-
+        databaseInfo.setTriggersCreateOrReplaceSupported(true);
     }
 
     @Override