0004393: Regression NPE in Postgres bulk loader factory

JumpMind · May 11, 2020 · 2697d93 · 2697d93
1 parent 6ca03e5
commit 2697d93
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/symmetric-client/src/main/java/org/jumpmind/symmetric/ext/PostgresBulkDataLoaderFactory.java b/symmetric-client/src/main/java/org/jumpmind/symmetric/ext/PostgresBulkDataLoaderFactory.java
@@ -38,7 +38,7 @@
 public class PostgresBulkDataLoaderFactory extends DefaultDataLoaderFactory {
 
     public PostgresBulkDataLoaderFactory(ISymmetricEngine engine) {
-        super(engine.getParameterService());
+        super(engine);
     }
 
     public String getTypeName() {

diff --git a/symmetric-core/src/main/java/org/jumpmind/symmetric/load/DefaultDataLoaderFactory.java b/symmetric-core/src/main/java/org/jumpmind/symmetric/load/DefaultDataLoaderFactory.java
@@ -48,7 +48,6 @@
 import org.jumpmind.symmetric.io.data.writer.KafkaWriter;
 import org.jumpmind.symmetric.io.data.writer.ResolvedData;
 import org.jumpmind.symmetric.io.data.writer.TransformWriter;
-import org.jumpmind.symmetric.service.IParameterService;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -61,8 +60,9 @@ public class DefaultDataLoaderFactory extends AbstractDataLoaderFactory implemen
     public DefaultDataLoaderFactory() {
     }
 
-    public DefaultDataLoaderFactory(IParameterService parameterService) {
-        this.parameterService = parameterService;
+    public DefaultDataLoaderFactory(ISymmetricEngine engine) {
+        this.engine = engine;
+        this.parameterService = engine.getParameterService();
     }
 
     public String getTypeName() {
@@ -216,7 +216,7 @@ protected DatabaseWriterSettings buildDatabaseWriterSettings(List<IDatabaseWrite
     @Override
     public void setSymmetricEngine(ISymmetricEngine engine) {
         this.engine = engine;
+        this.parameterService = engine.getParameterService();
     }
 
-
 }
diff --git a/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataLoaderService.java b/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/DataLoaderService.java
@@ -189,7 +189,7 @@ public DataLoaderService(ISymmetricEngine engine) {
         this.stagingManager = engine.getStagingManager();
         this.setSqlMap(new DataLoaderServiceSqlMap(platform, createSqlReplacementTokens()));
         extensionService = engine.getExtensionService();
-        extensionService.addExtensionPoint(new DefaultDataLoaderFactory(parameterService));
+        extensionService.addExtensionPoint(new DefaultDataLoaderFactory(engine));
         extensionService.addExtensionPoint(new ConfigurationChangedDatabaseWriterFilter(engine));
         this.nodeCommunicationService = engine.getNodeCommunicationService();
         this.engine = engine;