0006007: Prevented node from starting up if the sync.url is invalid

JumpMind · Oct 6, 2023 · 388db0a · 388db0a
1 parent 853746a
commit 388db0a
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/symmetric-core/src/main/java/org/jumpmind/symmetric/AbstractSymmetricEngine.java b/symmetric-core/src/main/java/org/jumpmind/symmetric/AbstractSymmetricEngine.java
@@ -27,6 +27,7 @@
 import java.lang.reflect.Constructor;
 import java.lang.reflect.Method;
 import java.net.MalformedURLException;
+import java.net.URISyntaxException;
 import java.net.URL;
 import java.security.UnrecoverableKeyException;
 import java.sql.SQLException;
@@ -984,7 +985,14 @@ public boolean isConfigured() {
                 log.debug("The current version of {} is newer than the last running version of {}",
                         Version.version(), node.getSymmetricVersion());
             }
-            configurationValid = true;
+            try {
+                new URL(parameterService.getSyncUrl()).toURI();
+            } catch (MalformedURLException e) {
+                errorMessage = String.format("The %s property is not a valid URL: %s", ParameterConstants.SYNC_URL, parameterService.getSyncUrl());
+            } catch (URISyntaxException e) {
+                errorMessage = String.format("The %s property is not a valid URI: %s", ParameterConstants.SYNC_URL, parameterService.getSyncUrl());
+            }
+            configurationValid = (errorMessage == null);
         }
         if (errorMessage != null) {
             log.error(errorMessage);