0006071: Prevented sym_node from getting updated unnecessarily when h…

…eartbeat.update.node.with.batch.status parameter is disabled
JumpMind · Oct 30, 2023 · 5870b29 · 5870b29
1 parent 07cb7c7
commit 5870b29
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/symmetric-core/src/main/java/org/jumpmind/symmetric/job/PushHeartbeatListener.java b/symmetric-core/src/main/java/org/jumpmind/symmetric/job/PushHeartbeatListener.java
@@ -119,17 +119,17 @@ public void heartbeat(Node me) {
                     || (engine.getParameterService().isRegistrationServer() && !Version.version().equals(me.getConfigVersion()))
                     || !symmetricDialect.getName().equals(me.getDatabaseType())
                     || !symmetricDialect.getVersion().equals(me.getDatabaseVersion())
-                    || me.getBatchInErrorCount() != batchInErrorCount
-                    || me.getBatchToSendCount() != outgoingUnsentCount
-                    || me.getLastSuccessfulSyncDate() != lastSuccessfulSyncTime
-                    || me.getMostRecentActiveTableSynced() != mostRecentActiveTableSynced
-                    || me.getPurgeOutgoingLastMs() != purgeOutgoingLastMs
-                    || me.getPurgeOutgoingLastRun() != purgeOutgoingLastRun
-                    || me.getPurgeOutgoingAverageMs() != purgeOutgoingAverage
-                    || me.getRoutingAverageMs() != routingAveragetMs
-                    || me.getRoutingLastRun() != routingLastRun
-                    || me.getRoutingLastMs() != routingLastMs
-                    || me.getSymDataSize() != symDataSize) {
+                    || (updateWithBatchStatus && (me.getBatchInErrorCount() != batchInErrorCount
+                            || me.getBatchToSendCount() != outgoingUnsentCount
+                            || me.getLastSuccessfulSyncDate() != lastSuccessfulSyncTime
+                            || me.getMostRecentActiveTableSynced() != mostRecentActiveTableSynced
+                            || me.getPurgeOutgoingLastMs() != purgeOutgoingLastMs
+                            || me.getPurgeOutgoingLastRun() != purgeOutgoingLastRun
+                            || me.getPurgeOutgoingAverageMs() != purgeOutgoingAverage
+                            || me.getRoutingAverageMs() != routingAveragetMs
+                            || me.getRoutingLastRun() != routingLastRun
+                            || me.getRoutingLastMs() != routingLastMs
+                            || me.getSymDataSize() != symDataSize))) {
                 log.info("Some attribute(s) of node changed.  Recording changes");
                 me.setDeploymentType(engine.getDeploymentType());
                 me.setDeploymentSubType(engine.getDeploymentSubType());