Fixed 0001559: If there are no primary keys defined when the database…

… writer is processing an update or delete report an error.
JumpMind · Feb 3, 2014 · 658fb07 · 658fb07
1 parent 277da04
commit 658fb07
Showing 1 changed file with 24 additions and 0 deletions.
diff --git a/symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/writer/DatabaseWriter.java b/symmetric-io/src/main/java/org/jumpmind/symmetric/io/data/writer/DatabaseWriter.java
@@ -596,6 +596,18 @@ protected LoadStatus delete(CsvData data, boolean useConflictDetection) {
                         }
                     }
                 }
+
+                int lookupKeyCountBeforeLobRemoval = lookupKeys.size();
+
+                if (lookupKeys.size() == 0) {
+                    String msg = "There are no keys defined for "
+                            + targetTable.getFullyQualifiedTableName()
+                            + ".  Cannot build an update statement.  ";
+                    if (lookupKeyCountBeforeLobRemoval > 0) {
+                        msg += "The only keys defined are binary and they have been removed.";
+                    }
+                    throw new IllegalStateException(msg);                        
+                }
 
                 lookupDataMap = getLookupDataMap(data);
 
@@ -723,6 +735,8 @@ protected LoadStatus update(CsvData data, boolean applyChangesOnly, boolean useC
                         lookupKeys = targetTable.getColumnsAsList();
                     }
 
+                    int lookupKeyCountBeforeLobRemoval = lookupKeys.size();
+
                     if (!platform.getDatabaseInfo().isBlobsWorkInWhereClause()
                             || data.isNoBinaryOldData()) {
                         Iterator<Column> it = lookupKeys.iterator();
@@ -733,6 +747,16 @@ protected LoadStatus update(CsvData data, boolean applyChangesOnly, boolean useC
                             }
                         }
                     }
+
+                    if (lookupKeys.size() == 0) {
+                        String msg = "There are no keys defined for "
+                                + targetTable.getFullyQualifiedTableName()
+                                + ".  Cannot build an update statement.  ";
+                        if (lookupKeyCountBeforeLobRemoval > 0) {
+                            msg += "The only keys defined are binary and they have been removed.";
+                        }
+                        throw new IllegalStateException(msg);                        
+                    }
 
                     lookupDataMap = getLookupDataMap(data);