Skip to content

Commit

Permalink
[ 1922524 ] PostgreSQL dialect tries to create existing triggers
Browse files Browse the repository at this point in the history
  • Loading branch information
erilong committed Mar 21, 2008
1 parent f9d2dd8 commit 6d0dc9e
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
14 changes: 14 additions & 0 deletions symmetric/src/changes/changes.xml
Expand Up @@ -27,6 +27,20 @@
zero. It should link to the sym_data.
</action>
</release>
<release version="1.3.1" date="2008-03-25" description="a brave new frontier, patched">
<action dev="erilong" type="fix" issue="aid=1922524&amp;atid=997724">
Fixed the PostgreSQL dialect to query for existence of triggers correctly, which
was causing it to try creating them on every startup.
</action>
<action dev="erilong" type="fix" issue="aid=1913260&amp;atid=997724">
Fixed the population of the failed_data_id on sym_outgoing_batch_hist, which was always
zero. It should link to the sym_data.
</action>
<action dev="chenson42" type="fix" issue="aid=1914242&amp;atid=997724">
The oracle dialect should select from user_objects vs. all_objects to determine if the
package variable has been installed.
</action>
</release>
<release version="1.3.0" date="2008-03-12" description="a brave new frontier">
<action dev="chenson42" type="add">
Changed Version.java to reference the pom.properties version that is packaged in the jar
Expand Down
Expand Up @@ -64,7 +64,7 @@ public boolean isFunctionUpToDate(String name) throws Exception {
: "";
return jdbcTemplate.queryForInt(
"select count(*) from information_schema.routines where created >= ? and routine_name = ?"
+ checkSchema, new Object[] { new Date(lastModified), name }) > 0;
+ checkSchema, new Object[] { new Date(lastModified), name.toLowerCase() }) > 0;
}

@Override
Expand All @@ -74,7 +74,7 @@ protected boolean doesTriggerExistOnPlatform(String schema, String tableName, St
+ schema + "'" : "";
return jdbcTemplate.queryForInt(
"select count(*) from information_schema.triggers where trigger_name like ? and event_object_table like ?"
+ checkSchema, new Object[] { triggerName, tableName }) > 0;
+ checkSchema, new Object[] { triggerName.toLowerCase(), tableName.toLowerCase() }) > 0;
}

public void removeTrigger(String schemaName, String triggerName) {
Expand Down

0 comments on commit 6d0dc9e

Please sign in to comment.