0005593: Incorrect Logic in various DDLBuilders for Processing Changes

JumpMind · Nov 21, 2022 · 7808473 · 7808473
1 parent ab2fe7e
commit 7808473
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/symmetric-db/src/main/java/org/jumpmind/db/platform/oracle/OracleDdlBuilder.java b/symmetric-db/src/main/java/org/jumpmind/db/platform/oracle/OracleDdlBuilder.java
@@ -506,7 +506,7 @@ protected boolean processChange(Database currentModel, Database desiredModel,
 
     protected void processChange(Database currentModel, Database desiredModel,
             ColumnRequiredChange change, StringBuilder ddl) {
-        boolean required = !change.getChangedColumn().isRequired();
+        boolean required = change.getChangedColumn().isRequired();
         writeTableAlterStmt(change.getChangedTable(), ddl);
         ddl.append(" MODIFY (");
         Column column = change.getChangedColumn();

diff --git a/symmetric-db/src/main/java/org/jumpmind/db/platform/postgresql/PostgreSqlDdlBuilder.java b/symmetric-db/src/main/java/org/jumpmind/db/platform/postgresql/PostgreSqlDdlBuilder.java
@@ -484,7 +484,7 @@ protected void processChange(Database currentModel, Database desiredModel,
 
     protected void processChange(Database currentModel, Database desiredModel,
             ColumnRequiredChange change, StringBuilder ddl) {
-        boolean required = !change.getChangedColumn().isRequired();
+        boolean required = change.getChangedColumn().isRequired();
         writeTableAlterStmt(change.getChangedTable(), ddl);
         ddl.append(" ALTER COLUMN ");
         Column column = change.getChangedColumn();

diff --git a/symmetric-db/src/main/java/org/jumpmind/db/platform/tibero/TiberoDdlBuilder.java b/symmetric-db/src/main/java/org/jumpmind/db/platform/tibero/TiberoDdlBuilder.java
@@ -445,7 +445,7 @@ protected boolean processChange(Database currentModel, Database desiredModel,
 
     protected void processChange(Database currentModel, Database desiredModel,
             ColumnRequiredChange change, StringBuilder ddl) {
-        boolean required = !change.getChangedColumn().isRequired();
+        boolean required = change.getChangedColumn().isRequired();
         writeTableAlterStmt(change.getChangedTable(), ddl);
         ddl.append(" MODIFY (");
         Column column = change.getChangedColumn();