Skip to content

Commit

Permalink
0001277: NPE during conflict resolution (use_version -> newer_wins)
Browse files Browse the repository at this point in the history
  • Loading branch information
chenson42 committed Jun 13, 2013
1 parent 1c032ae commit 8089a0a
Showing 1 changed file with 8 additions and 4 deletions.
Expand Up @@ -293,10 +293,14 @@ protected boolean isVersionNewer(Conflict conflict, DatabaseWriter writer, CsvDa
String sql = stmt.getColumnsSql(new Column[] { targetTable.getColumnWithName(columnName) });
Long existingVersion = writer.getTransaction()
.queryForObject(sql, Long.class, objectValues);
Map<String, String> newData = data.toColumnNameValuePairs(sourceTable.getColumnNames(),
CsvData.ROW_DATA);
Long loadingVersion = Long.valueOf(newData.get(columnName));
return loadingVersion > existingVersion;
if (existingVersion == null) {
return true;
} else {
Map<String, String> newData = data.toColumnNameValuePairs(sourceTable.getColumnNames(),
CsvData.ROW_DATA);
Long loadingVersion = Long.valueOf(newData.get(columnName));
return loadingVersion > existingVersion;
}
}

protected void performFallbackToUpdate(DatabaseWriter writer, CsvData data, Conflict conflict, boolean retransform) {
Expand Down

0 comments on commit 8089a0a

Please sign in to comment.