Skip to content

Commit

Permalink
dev checkin. another small fix. db2.
Browse files Browse the repository at this point in the history
  • Loading branch information
chenson42 committed Feb 15, 2012
1 parent 7cc656f commit 8addbbb
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
1 change: 1 addition & 0 deletions symmetric/symmetric-assemble/TODO.txt
Expand Up @@ -62,6 +62,7 @@ DONE = +

* Test timezone columns. Do other databases other than oracle and postgres have timezone columns?
* Test batch insert performance during routing (esp on oracle)
* Test to make sure that autocreate for all databases doesn't recreate symmetricds artifacts every time it is run (DB2 might be having an issue right now)

Performance Improvement Opportunities
* Pluggable data loaders
Expand Down
Expand Up @@ -371,8 +371,8 @@ public static int insert(Object[] values, ISqlTemplate jdbcTemplate, ISymmetricD
}

protected static boolean isBooleanSupported(ISymmetricDialect dbDialect) {
return !(DatabaseNamesConstants.ORACLE.equals(dbDialect.getName()) || DatabaseNamesConstants.DB2
.equals(dbDialect.getName()));
return !(DatabaseNamesConstants.ORACLE.equals(dbDialect.getPlatform().getName()) || DatabaseNamesConstants.DB2
.equals(dbDialect.getPlatform().getName()));
}

protected static Object[] filterValues(Object[] values, ISymmetricDialect dbDialect) {
Expand Down
Expand Up @@ -25,6 +25,7 @@

import org.apache.commons.lang.StringUtils;
import org.jumpmind.db.platform.AbstractJdbcDatabasePlatform;
import org.jumpmind.db.platform.DatabaseNamesConstants;
import org.jumpmind.db.platform.DatabasePlatformSettings;

/*
Expand All @@ -33,7 +34,7 @@
public class Db2Platform extends AbstractJdbcDatabasePlatform {

/* Database name of this platform. */
public static final String DATABASENAME = "DB2";
public static final String DATABASENAME = DatabaseNamesConstants.DB2;

/* The standard DB2 jdbc driver. */
public static final String JDBC_DRIVER = "com.ibm.db2.jcc.DB2Driver";
Expand Down

0 comments on commit 8addbbb

Please sign in to comment.