0005483: Toggle to convert TEXT to VARCHAR in MS SQL (#186)

* Set env var USE_VARCHAR_FOR_TEXT to create varchar for text types * Use property for setting text-to-varchar * Use short if for N-type
JumpMind · Sep 30, 2022 · b47dcc3 · b47dcc3
1 parent 2679844
commit b47dcc3
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/symmetric-db/src/main/java/org/jumpmind/db/platform/mssql/MsSql2005DdlBuilder.java b/symmetric-db/src/main/java/org/jumpmind/db/platform/mssql/MsSql2005DdlBuilder.java
@@ -21,6 +21,7 @@
 package org.jumpmind.db.platform.mssql;
 
 import java.sql.Types;
+import java.util.Map;
 
 import org.jumpmind.db.model.Column;
 import org.jumpmind.db.model.Table;
@@ -87,6 +88,7 @@ protected void dropColumnChangeDefaults(Table sourceTable, Column sourceColumn,
 
     @Override
     public String getSqlType(Column column) {
+        boolean useVarcharForText = System.getProperty("mssql.use.varchar.for.lob", "false").equalsIgnoreCase("true");
         String sqlType = super.getSqlType(column);
         if (column.getMappedTypeCode() == Types.VARBINARY && column.getSizeAsInt() > 8000) {
             sqlType = "VARBINARY(MAX)";
@@ -96,6 +98,10 @@ public String getSqlType(Column column) {
             sqlType = "NVARCHAR(MAX)";
         } else if (column.getMappedTypeCode() == Types.DECIMAL && column.getSizeAsInt() > 38) {
             sqlType = String.format("DECIMAL(38,%d)", column.getScale());
+        } else if (useVarcharForText && (column.getMappedTypeCode() == Types.LONGVARCHAR || column.getMappedTypeCode() == Types.LONGNVARCHAR || column
+                .getMappedTypeCode() == Types.CLOB)) {
+            sqlType = (column.getMappedTypeCode() == Types.LONGNVARCHAR) ? "N" : "";
+            sqlType += "VARCHAR(MAX)";
         }
         return sqlType;
     }