0005873: Open Registration in Rest API doesn't allow user to specify

node if 2 nodes have the same external ID
JumpMind · Jun 12, 2023 · b7d0fd5 · b7d0fd5
1 parent 644ec5c
commit b7d0fd5
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/symmetric-server/src/main/java/org/jumpmind/symmetric/web/rest/RestService.java b/symmetric-server/src/main/java/org/jumpmind/symmetric/web/rest/RestService.java
@@ -879,8 +879,10 @@ public final RegistrationInfo postRegisterNode(@PathVariable("engine") String en
     @ResponseBody
     public final String postOpenRegistration(
             @RequestParam(value = "nodeGroupId") String nodeGroupId,
-            @RequestParam(value = "externalId") String externalId) {
-        return postOpenRegistration(getSymmetricEngine().getEngineName(), nodeGroupId, externalId);
+            @RequestParam(value = "externalId") String externalId,
+            @RequestParam(value = "hostName", required = false) String hostName,
+            @RequestParam(value = "ipAddress", required = false) String ipAddress) {
+        return postOpenRegistration(getSymmetricEngine().getEngineName(), nodeGroupId, externalId, hostName, ipAddress);
     }
 
     @ApiOperation(value = "Open registration for the specified node at the specified engine")
@@ -889,9 +891,11 @@ public final String postOpenRegistration(
     @ResponseBody
     public final String postOpenRegistration(@PathVariable("engine") String engineName,
             @RequestParam(value = "nodeGroupId") String nodeGroupId,
-            @RequestParam(value = "externalId") String externalId) {
+            @RequestParam(value = "externalId") String externalId,
+            @RequestParam(value = "hostName", required = false) String hostName,
+            @RequestParam(value = "ipAddress", required = false) String ipAddress) {
         ISymmetricEngine engine = getSymmetricEngine(engineName);
-        return engine.getRegistrationService().openRegistration(nodeGroupId, externalId);
+        return engine.getRegistrationService().openRegistration(nodeGroupId, externalId, hostName, ipAddress);
     }
 
     /**