Skip to content

Commit

Permalink
0005604: Check sync URL ends with engine name
Browse files Browse the repository at this point in the history
  • Loading branch information
erilong committed Nov 28, 2022
1 parent a09a8ce commit dcf993d
Showing 1 changed file with 4 additions and 1 deletion.
Expand Up @@ -699,7 +699,7 @@ protected void checkSystemIntegrity(Node node) {
boolean streamToFile = parameterService.is(ParameterConstants.STREAM_TO_FILE_ENABLED, true);
if (useExtractJob && !streamToFile) {
throw new SymmetricException(String.format(
"Node '%s' is configured with confilcting parameters which may result in replication stopping and/or empty load batches. "
"Node '%s' is configured with conflicting parameters which may result in replication stopping and/or empty load batches. "
+ "One of these two parameters needs to be changed: %s=%s and %s=%s",
node != null ? node.getNodeId() : "null", ParameterConstants.INITIAL_LOAD_USE_EXTRACT_JOB,
useExtractJob, ParameterConstants.STREAM_TO_FILE_ENABLED, streamToFile));
Expand Down Expand Up @@ -932,6 +932,9 @@ public boolean isConfigured() {
log.warn(
"SymmetricDS does not support automatic downgrading. The current version running version of {} is older than the last running version of {}",
Version.version(), node.getSymmetricVersion());
} else if (!StringUtils.isBlank(parameterService.getSyncUrl()) && !parameterService.getSyncUrl().endsWith(parameterService.getEngineName())) {
log.error("The engine is named '{}' but the {} property does not end with the same engine name: {}", parameterService.getEngineName(),
ParameterConstants.SYNC_URL, parameterService.getSyncUrl());
} else {
if (node != null && Version.isOlderMinorVersion(node.getSymmetricVersion(), Version.version())) {
log.debug("The current version of {} is newer than the last running version of {}",
Expand Down

0 comments on commit dcf993d

Please sign in to comment.