Skip to content

Commit

Permalink
give better error for user if transform_point has an invalid value.
Browse files Browse the repository at this point in the history
  • Loading branch information
chenson42 committed Feb 28, 2012
1 parent b0ea5ea commit eae74cf
Showing 1 changed file with 10 additions and 4 deletions.
@@ -1,6 +1,7 @@
package org.jumpmind.symmetric.service.impl;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -173,15 +174,17 @@ public void saveTransformTable(TransformTableNodeGroupLink transformTable) {
}

protected void deleteTransformColumns(ISqlTransaction transaction, String transformTableId) {
transaction.prepareAndExecute(getSql("deleteTransformColumnsSql"), (Object) transformTableId);
transaction.prepareAndExecute(getSql("deleteTransformColumnsSql"),
(Object) transformTableId);
}

public void deleteTransformTable(String transformTableId) {
ISqlTransaction transaction = null;
try {
transaction = sqlTemplate.startSqlTransaction();
deleteTransformColumns(transaction, transformTableId);
transaction.prepareAndExecute(getSql("deleteTransformTableSql"), (Object) transformTableId);
transaction.prepareAndExecute(getSql("deleteTransformTableSql"),
(Object) transformTableId);
refreshCache();
transaction.commit();
} finally {
Expand Down Expand Up @@ -231,9 +234,12 @@ public TransformTableNodeGroupLink mapRow(Row rs) {
table.setTargetSchemaName(rs.getString("target_schema_name"));
table.setTargetTableName(rs.getString("target_table_name"));
try {
table.setTransformPoint(TransformPoint.valueOf(rs.getString("transform_point").toUpperCase()));
table.setTransformPoint(TransformPoint.valueOf(rs.getString("transform_point")
.toUpperCase()));
} catch (RuntimeException ex) {
log.warn("Invalid value provided for transform_point: {}", rs.getString("transform_point"));
log.warn(
"Invalid value provided for transform_point of '{}.' Valid values are: {}",
rs.getString("transform_point"), Arrays.toString(TransformPoint.values()));
throw ex;
}
table.setTransformOrder(rs.getInt("transform_order"));
Expand Down

0 comments on commit eae74cf

Please sign in to comment.