0005466: Push registration, when sync URL is empty for registering node,

should allow Pull registration to recover from empty sync URL
JumpMind · Sep 22, 2022 · f195619 · f195619
1 parent 62ad086
commit f195619
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RegistrationService.java b/symmetric-core/src/main/java/org/jumpmind/symmetric/service/impl/RegistrationService.java
@@ -308,8 +308,12 @@ public boolean registerNode(Node nodePriorToRegistration, String remoteHost,
                                 nodePriorToRegistration, remoteHost, remoteAddress) : nodePriorToRegistration.getNodeId();
                 NodeSecurity nodeSecurity = nodeService.findNodeSecurity(nodeId);
                 if (nodeSecurity != null && nodeSecurity.isRegistrationEnabled()) {
-                    log.debug("Pull of registration from {} is being ignored because group link is push", nodePriorToRegistration);
-                    return true;
+                    // Make sure sync URL is set before skipping this registration request
+                    Node node = nodeService.findNode(nodeId);
+                    if (node != null && node.getSyncUrl() != null && node.getSyncUrl().length() > 0) {
+                        log.debug("Pull of registration from {} is being ignored because group link is push", nodePriorToRegistration);
+                        return true;
+                    }
                 }
             }
         }