0004345: Postgres array types improperly cast into non-array types

JumpMind · May 11, 2021 · f22fa39 · f22fa39
1 parent b17543d
commit f22fa39
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/symmetric-db/src/main/java/org/jumpmind/db/platform/postgresql/PostgreSqlDmlStatement.java b/symmetric-db/src/main/java/org/jumpmind/db/platform/postgresql/PostgreSqlDmlStatement.java
@@ -143,7 +143,7 @@ protected void appendColumnEquals(StringBuilder sql, Column column) {
 
         if (typeToCast != null) {
             sql.append(quote).append(column.getName()).append(quote)
-                    .append(" = cast(? as ").append(typeToCast).append(")").append(",");
+                    .append(" = cast(? as ").append(typeToCast).append(")");
         } else if (column.getJdbcTypeName() != null && (
                 column.getJdbcTypeName().toUpperCase().contains(TypeMap.GEOMETRY) ||
                 column.getJdbcTypeName().toUpperCase().contains(TypeMap.GEOGRAPHY))) {

diff --git a/...ic-jdbc/src/main/java/org/jumpmind/db/platform/postgresql/PostgreSqlDatabasePlatform.java b/...ic-jdbc/src/main/java/org/jumpmind/db/platform/postgresql/PostgreSqlDatabasePlatform.java
@@ -357,4 +357,11 @@ public String getSliceTableSql(String columnName, int sliceNum, int totalSlices)
         return "ascii(substring(" + columnName + ", 1, 1)) % " + totalSlices + " = " + sliceNum;
     }
 
+    @Override
+    public boolean canColumnBeUsedInWhereClause(Column column) {
+        if (column.getJdbcTypeName() != null && column.getJdbcTypeName().startsWith("json")) {
+            return false;
+        }
+        return true;
+    }
 }