-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Control node crash when handling config client reinit:
The config client can be reinit through a signal or if some config params changed. While processing the reinit, the config manager tries to shutdown and recreate the config db client. The config client and its associated partition tasks cannot be running since they are mutually exclusive tasks to the client init task and this is a valid assumption. However, it is possible that the tasks have been scheduled to run but yet to begin execution. If that is the case and we try to shutdown the config db client/partition, TaskTriggers assert if there are scheduled tasks. This is not a problem for WorkQueue and Task classes. Fixing this for TaskTrigger tasks by checking if they have been scheduled and retrying the config init. UT will be done at a later time when the test infra for reinit code is added. For now, verified that the config client tests pass. Change-Id: Id6d9c6aed32d32688d88932a8ec6c85a5207ad28 Partial-Bug: 1786154
- Loading branch information
Showing
5 changed files
with
39 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters