Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Coverity issue in contrail-controller/acl.cc
I have run Coverity on branch R5.0 and it reported the following issue in contrail-controller/acl.cc:FirewallPolicyIFNodeToReq() uninit_use_in_call: Using uninitialized value ace_spec.type when calling Reverse I've noticed that type field is indeed set in Reverse() function, but its value is never checked (for instance, in an if clause). A solution I have found is to add another field, named NOT_USED, in enum AclTypeSpec and initialize "type" field with NOT_USED in constructor. Change-Id: I6cbc8063d7ac01644a97edd30cf021d41c8fe303 Closes-Bug: #1777452 Signed-off-by: Anda Nicolae <anicolae@lenovo.com>
- Loading branch information