Merge "Coverity issues in contrail-controller/agent_param.cc"

Juniper · Jun 5, 2018 · 7cb8289 · 7cb8289
2 parents 135111b + e055240
commit 7cb8289
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/vnsw/agent/init/agent_param.cc b/src/vnsw/agent/init/agent_param.cc
@@ -955,7 +955,7 @@ static bool ValidateInterface(bool test_mode, const std::string &ifname,
 
     struct ifreq ifr;
     memset(&ifr, 0, sizeof(ifr));
-    strncpy(ifr.ifr_name, ifname.c_str(), IF_NAMESIZE);
+    strncpy(ifr.ifr_name, ifname.c_str(), IF_NAMESIZE-1);
     int err = ioctl(fd, SIOCGIFFLAGS, (void *)&ifr);
     close (fd);
 
@@ -979,6 +979,7 @@ static bool ValidateInterface(bool test_mode, const std::string &ifname,
                 *eth_encap = "none";
             }
         }
+        fclose(f);
     }
 #endif