Skip to content

Commit

Permalink
* Dont export multicast route upon VRF delete
Browse files Browse the repository at this point in the history
Ideally upon VRF delete control-node implictly deletes all the
paths added by agent in particular VRF, in problematic scenario
after VRF unsubscribe was done agent used to send a route delete
for multicast route, resulting in control-node closing the channel.

Change-Id: I440fa9bc561bf50229a7134122093d487b93bfb7
Closes-bug: #1716356
  • Loading branch information
naveen-n committed Sep 12, 2017
1 parent a2bd446 commit 8e388d2
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/vnsw/agent/controller/controller_export.cc
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,12 @@ void RouteExport::MulticastNotify(AgentXmppChannel *bgp_xmpp_peer,
State *state = static_cast<State *>(route->GetState(partition->parent(), id_));
bool route_can_be_dissociated = MulticastRouteCanDissociate(route);

if (marked_delete_ && state) {
route->ClearState(partition->parent(), id_);
delete state;
state = NULL;
return;
}
//Handle withdraw for following cases:
//- Route is not having any active multicast exportable path or is deleted.
//- associate(false): Bgp Peer has gone down and state needs to be removed.
Expand Down

0 comments on commit 8e388d2

Please sign in to comment.