Skip to content

Commit

Permalink
Minor update to parameter description in Firewall Rule workflows
Browse files Browse the repository at this point in the history
Change-Id: I4051dd5d54bda037cfc3e3b17ead497fac536cb2
Closes-Bug: #1772594
  • Loading branch information
danieljasinski committed Jun 13, 2018
1 parent 9db7112 commit 2bbb8b4
Showing 1 changed file with 4 additions and 1 deletion.
Expand Up @@ -85,6 +85,7 @@ internal fun editFirewallRule(schema: Schema): WorkflowDefinition {
return customWorkflow<FirewallRule>(workflowName).withScriptFile("editFirewallRule") {
step("Rule") {
parameter("rule", reference<FirewallRule>()) {
description = "Rule to edit"
mandatory = true
}
}
Expand Down Expand Up @@ -116,6 +117,7 @@ private fun PresentationParametersBuilder.firewallRuleParameters(schema: Schema,
step("Service") {
visibility = WhenNonNull(visibilityDependencyField)
parameter(serviceTypeParameterName, string) {
description = "Service Type"
mandatory = true
predefinedAnswers = allowedServiceTypes
defaultValue = defaultServiceType
Expand Down Expand Up @@ -143,7 +145,7 @@ private fun PresentationParametersBuilder.firewallRuleParameters(schema: Schema,
if (loadCurrentValues) dataBinding = firewallRulePropertyDataBinding("serviceDstPorts()")
}
parameter("serviceReference", reference<ServiceGroup>()) {
description = "Service group"
description = "Service Group"
visibility = FromStringParameter(serviceTypeParameterName, ServiceType.Reference.value)
mandatory = true
if (loadCurrentValues) dataBinding = firewallRulePropertyDataBinding("serviceGroup[0]")
Expand All @@ -152,6 +154,7 @@ private fun PresentationParametersBuilder.firewallRuleParameters(schema: Schema,
step("Match Tags") {
visibility = WhenNonNull(visibilityDependencyField)
parameter("matchTags", array(string)) {
description = "Match Tags"
predefinedAnswers = allowedMatchTags
sameValues = false
if (loadCurrentValues) dataBinding = firewallRulePropertyDataBinding("matchTags.tagList")
Expand Down

0 comments on commit 2bbb8b4

Please sign in to comment.