Skip to content

Commit

Permalink
Merge pull request #116 from anxdpanic/tw
Browse files Browse the repository at this point in the history
allow user to force verification of ssl certificate
  • Loading branch information
jdf76 committed Nov 21, 2016
2 parents 693b851 + d4390f1 commit 8ec5a13
Show file tree
Hide file tree
Showing 23 changed files with 96 additions and 2 deletions.
4 changes: 4 additions & 0 deletions resources/language/Bulgarian/strings.po
Expand Up @@ -577,3 +577,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Chinese (Traditional)/strings.po
Expand Up @@ -577,3 +577,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Czech/strings.po
Expand Up @@ -577,3 +577,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Dutch/strings.po
Expand Up @@ -586,3 +586,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/English/strings.po
Expand Up @@ -594,3 +594,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/French/strings.po
Expand Up @@ -586,3 +586,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/German/strings.po
Expand Up @@ -577,3 +577,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Greek/strings.po
Expand Up @@ -592,3 +592,7 @@ msgstr "Αποτυχία"
msgctxt "#30577"
msgid "Settings"
msgstr "Ρυθμίσεις"

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Hebrew/strings.po
Expand Up @@ -577,3 +577,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Hungarian/strings.po
Expand Up @@ -577,3 +577,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Italian/strings.po
Expand Up @@ -577,3 +577,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Korean/strings.po
Expand Up @@ -577,3 +577,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Norwegian/strings.po
Expand Up @@ -594,3 +594,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Polish/strings.po
Expand Up @@ -577,3 +577,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Portuguese (Brazil)/strings.po
Expand Up @@ -575,3 +575,7 @@ msgstr "Falhou"
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Portuguese/strings.po
Expand Up @@ -577,3 +577,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Romanian/strings.po
Expand Up @@ -577,3 +577,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Russian/strings.po
Expand Up @@ -586,3 +586,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Slovak/strings.po
Expand Up @@ -577,3 +577,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Spanish/strings.po
Expand Up @@ -577,3 +577,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
4 changes: 4 additions & 0 deletions resources/language/Ukrainian/strings.po
Expand Up @@ -577,3 +577,7 @@ msgstr ""
msgctxt "#30577"
msgid "Settings"
msgstr ""

msgctxt "#30578"
msgid "Force SSL Certificate verification"
msgstr ""
13 changes: 11 additions & 2 deletions resources/lib/kodion/simple_requests/api.py
Expand Up @@ -7,6 +7,10 @@

import json as real_json
from ..utils import to_utf8
from .. import Context as __Context

__context = __Context()
__settings = __context.get_settings()


class ErrorHandler(urllib2.HTTPDefaultErrorHandler):
Expand Down Expand Up @@ -71,8 +75,13 @@ def _request(method, url,
handlers = []

import sys

_verify = __settings.get_bool('simple.requests.ssl.verify', False)
if _verify:
verify = _verify

# starting with python 2.7.9 urllib verifies every https request
if False == verify and sys.version_info >= (2, 7, 9):
if verify is False and sys.version_info >= (2, 7, 9):
import ssl

ssl_context = ssl.create_default_context()
Expand Down Expand Up @@ -194,4 +203,4 @@ def delete(url, **kwargs):


def head(url, **kwargs):
return _request('HEAD', url, **kwargs)
return _request('HEAD', url, **kwargs)
1 change: 1 addition & 0 deletions resources/settings.xml
Expand Up @@ -40,6 +40,7 @@
</category>

<category label="30031">
<setting id="simple.requests.ssl.verify" type="bool" label="30578" default="false"/>
<setting id="kodion.support.alternative_player" type="bool" label="30036" default="false"/>
<setting id="youtube.view.description.show_channel_name" type="bool" label="30541" default="true"/>
<setting type="sep" />
Expand Down

0 comments on commit 8ec5a13

Please sign in to comment.