Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split to each packages (ivy, helm and polymode) #386

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

hwiorn
Copy link
Contributor

@hwiorn hwiorn commented Feb 19, 2023

Split org-brain.el to org-brain-ivy.el, org-brain-helm.el and org-brain-polymode.el for removing with-eval-after-load clauses.

Fix #384

@hwiorn
Copy link
Contributor Author

hwiorn commented Mar 1, 2023

@Kungsgeten I'm sorry to bother you of previous mistake. Could you check this PR?

@Kungsgeten
Copy link
Owner

Hi! Unfortunately I don't have much time to spend on my Emacs packages at the moment. I've looked at your PR and noticed that there were some documentation that I'd want to change (like the comments at the top of the file, and I think you're using a non-standard version of use-package in the README). I'm grateful for the PR though, and hope I'll be able to look into it further next week.

@hwiorn
Copy link
Contributor Author

hwiorn commented Mar 3, 2023

and I think you're using a non-standard version of use-package in the README

You are Right. I forgot to remove the exclamation mark. I use use-package wrapper which of doomemacs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbol’s value as variable is void: org-brain-poly-hostmode when ein:jupyter-server-start
2 participants