Drop ExaminationsController#show

KyivKrishnaAcademy · Mar 6, 2023 · e0a4b25 · e0a4b25
1 parent b57f32a
commit e0a4b25
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 16 deletions.
diff --git a/app/controllers/examinations_controller.rb b/app/controllers/examinations_controller.rb
@@ -1,12 +1,8 @@
 class ExaminationsController < HtmlRespondableController
-  before_action :set_examination, only: %i[show edit update destroy]
+  before_action :set_examination, only: %i[edit update destroy]
 
   after_action :verify_authorized
 
-  def show
-    respond_with(@examination)
-  end
-
   def new
     @examination = Examination.new(passing_score: 1, min_result: 0, max_result: 1, course_id: params[:course_id])
 
@@ -24,13 +20,13 @@ def create
 
     @examination.save
 
-    respond_with(@examination, location: -> { course_examination_path(params[:course_id], @examination.id) })
+    respond_with(@examination, location: -> { course_path(@examination.course_id) })
   end
 
   def update
     @examination.update(examination_params)
 
-    respond_with(@examination, location: -> { course_examination_path(params[:course_id], @examination.id) })
+    respond_with(@examination, location: -> { course_path(@examination.course_id) })
   end
 
   def destroy

diff --git a/app/views/courses/show.html.haml b/app/views/courses/show.html.haml
@@ -88,10 +88,7 @@
           %tbody
             - @examinations.each do |examination|
               %tr
-                %td
-                  = link_to_if policy(examination).show?, examination.title, course_examination_path(examination.course_id, examination) do
-                    = examination.title
-
+                %td= examination.title
                 %td.col-xs-1= examination.min_result
                 %td.col-xs-1= examination.max_result
                 %td.col-xs-1= examination.passing_score

diff --git a/app/views/examinations/show.html.haml b/app/views/examinations/show.html.haml
diff --git a/config/routes.rb b/config/routes.rb
@@ -45,7 +45,7 @@
   resource :subscriptions, only: %i[edit update]
 
   resources :courses do
-    resources :examinations, only: %i[new create edit update show destroy]
+    resources :examinations, only: %i[new create edit update destroy]
   end
 
   resources :programs, only: %i[new create edit update index destroy]

diff --git a/spec/controllers/examinations_controller_spec.rb b/spec/controllers/examinations_controller_spec.rb
@@ -6,7 +6,7 @@
   Given(:nested_route_params) { { course_id: course.id } }
 
   describe 'not signed in' do
-    it_behaves_like :failed_auth_crud, :not_authenticated, %i[index]
+    it_behaves_like :failed_auth_crud, :not_authenticated, %i[index show]
   end
 
   describe 'signed in' do
@@ -20,7 +20,7 @@
     describe 'as regular user' do
       Given(:default_id) { examination.id }
 
-      it_behaves_like :failed_auth_crud, :not_authorized, %i[index]
+      it_behaves_like :failed_auth_crud, :not_authorized, %i[index show]
     end
 
     describe 'as admin' do