-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support explicit coarse- and fine-grained allocations #807
Open
mcfadden8
wants to merge
134
commits into
develop
Choose a base branch
from
feature/mcfadden8/coarse_grain_allocator
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@davidbeckingsale, I am done with my changes to support this feature and I think this is ready for review. At this point, I believe that this should be ready (or close to ready) to merge. |
This comment was marked as resolved.
This comment was marked as resolved.
This reverts commit 6f57a16.
…re/mcfadden8/coarse_grain_allocator
…:LLNL/Umpire into feature/mcfadden8/coarse_grain_allocator
…oarse_grain_allocator' into feature/mcfadden8/coarse_grain_allocator
davidbeckingsale
changed the title
Feature/mcfadden8/coarse grain allocator
Support explicit coarse- and fine-grained allocations
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With HIP devices, we have the ability to influence how coherency of memory that is shared between devices and host processors.
This PR introduces a new
GranularityController
strategy that may be used to specify a cohrerency mode that an alloocator will produce. Two options are currently offered,FineGrainedCoherence
andCoarseGrainedCoherence
. The former means that coherency will be maintained and the latter is not guarunteed to be maintained until after a synchronization operation has been done with the using device.