Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add URL blocklist #245

Merged
merged 4 commits into from Mar 13, 2024
Merged

Add URL blocklist #245

merged 4 commits into from Mar 13, 2024

Conversation

flamingo-cant-draw
Copy link
Contributor

Needed for LemmyNet/lemmy#4515

dessalines
dessalines approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thx

SleeplessOne1917
SleeplessOne1917 requested changes Mar 13, 2024
View reviewed changes
Copy link
Member

@SleeplessOne1917 SleeplessOne1917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add the method for this on the client class.

@flamingo-cant-draw
Copy link
Contributor Author

I don't think new methods are necessary? Getting/setting is done through getSite/editSite respectively.

SleeplessOne1917
SleeplessOne1917 approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@SleeplessOne1917 SleeplessOne1917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, I thought this made a new API endpoint. My bad.

@SleeplessOne1917 SleeplessOne1917 enabled auto-merge (squash) March 13, 2024 21:41
@SleeplessOne1917 SleeplessOne1917 merged commit 8fd4367 into LemmyNet:main Mar 13, 2024
1 check passed
@dessalines
Copy link
Member

Another that was prematurely merged.

dessalines added a commit that referenced this pull request Mar 14, 2024
@dessalines
Revert "Add URL blocklist (#245)"
cb12cae 
This reverts commit 8fd4367.
@dessalines dessalines mentioned this pull request Mar 14, 2024
Merged
dessalines added a commit that referenced this pull request Mar 14, 2024
@dessalines
Revert "Add URL blocklist (#245)" (#248)
e449cf8 
This reverts commit 8fd4367.
dessalines added a commit that referenced this pull request Mar 14, 2024
@dessalines
Reapply "Add URL blocklist (#245)" (#248)
d7304db 
This reverts commit e449cf8.
dessalines added a commit that referenced this pull request Mar 15, 2024
@dessalines
Reapply "Add URL blocklist (#245)" (#248) (#249)
657c1f1 
This reverts commit e449cf8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines approved these changes

@SleeplessOne1917 SleeplessOne1917 SleeplessOne1917 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flamingo-cant-draw @dessalines @SleeplessOne1917