Lazy load translations and date-fns, server side support for "Browser Default" language #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matc-pub
requested review from
dessalines,
SleeplessOne1917,
alectrocute and
jsit
as code owners
Only when no translations and date-fns have to be dynamically loaded (e.g. for en-US) the NavBar `componentDidMount` is early enough to listen for "DOMContentLoaded". Removes one redundant `requestNotificationPermission()` call.
Browsers ask for "pt-BR", but the "interface_language" saved in the settings dialog asks for "pt_BR". This change will make the settings dialog ask for "pt-BR" instead of "pt_BR". For users that already (or still) have "pt_BR" configured, "pt-BR" will be used, but the settings dialog will present it as unspecified.
matc-pub
force-pushed
the
lazy_translation
branch
from
0f2b6a1
to
3909238
Compare
dessalines
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Tested this also, and everything works well. This late-loading stuff is magic to me, but it appears to work. I'll let @SleeplessOne1917 also take a look.
SleeplessOne1917
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lazy loads i18n translations and date-fns using dynamic imports.
Before
Both scripts are always loaded.
After
For "en-US" only
client.jsis loaded. "en-GB" and "en-CA" additionally load onedate-fns-*client.js, Most languages load onetranslation-*.client.jsand onedate-fns-*.client.js. Languages like "pt-BR", for which a specific (pt-BR) and general (pt) translation exists, load two translations and one date-fns.date-fnsare picked to match the language that i18n uses.Uses the "Accept-Language" header to determine which language to use for server side rendering. This also allows to load translations and date-fns in parallel with
client.js.The language code for "pt-BR" is no longer "pt_BR".
"DOMContentLoaded" (used for Notification permission) started working when only
client.jsis needed.