View mod history for a post or comment. Fixes #4162 #4491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doing a separate GetModlog call for each post/comment seems extremely inefficient. I think it would be much better if we could include this data in PostView/CommentView. |
|
That would add a lot more joins to various mod tables, probably hurt performance, and would also be potentially pointless data coming back. On-demand is probably better for this one. The idea was to use the |
Nutomic
approved these changes
Mar 4, 2024
|
Alright. The changes here are very simple so thats definitely a big advantage over using joins. Do you want to merge it directly? |
|
Yeah sure, its not breaking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.