Dont require leading ! or @ for webfinger resolve #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
reviewed
Mar 8, 2024
| @@ -18,28 +19,22 @@ use url::Url; | |||
| /// which gets resolved to an URL. | |||
| #[tracing::instrument(skip_all)] | |||
| pub(crate) async fn search_query_to_object_id( | |||
| query: &str, | |||
| mut query: String, | |||
There was a problem hiding this comment.
Instead of having this a a mutable param, I think it'd be better to just create a new var inside this function. immutable functions and all that.
There was a problem hiding this comment.
Unfortunately String::remove only works on a mutable string, and I dont see a better alternative in this case. Sure I could declare a separate mut inside the function, but that wouldnt really change anything.
There was a problem hiding this comment.
It's still an immutable function. mut before a parameter name does the same thing as putting let mut foo = foo; in the function body.
| ), | ||
| _ => return Err(LemmyErrorType::InvalidQuery)?, | ||
| if query.starts_with('!') || query.starts_with('@') { | ||
| query.remove(0); |
There was a problem hiding this comment.
You could just build the new var here. let query_2 = if .... else
dessalines
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this requirement is totally unnecessary as we can determine the type from the response. Only limitation is if there is a community and user with the same name, then it may be necessary to fetch by url.