Fix missing private key for signed fetch #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
force-pushed
the
fix-signed-fetch
branch
3 times, most recently
from
f9795cc
to
0531b47
Compare
Nutomic
commented
Mar 7, 2024
| .await?; | ||
|
|
||
| res.site.private_key = None; | ||
| Ok(res) |
There was a problem hiding this comment.
The output of this function is used for signed fetch, and it would crash due to missing private key. Actually there should be no need to set it as None, we can simply use serde(skip).
Nutomic
force-pushed
the
fix-signed-fetch
branch
from
0531b47
to
d043d6d
Compare
Nutomic
commented
Mar 7, 2024
dessalines
approved these changes
Mar 8, 2024
| pub private_key: Option<String>, | ||
| #[serde(skip)] |
There was a problem hiding this comment.
Doesn't the pub key need to get sent elsewhere? I guess the federation tests would be failing if that weren't the case.
There was a problem hiding this comment.
Yes but that is done in a separate struct. You can compare the db structs for user or community which have the same skip attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes Im able to fetch a Mastodon user that requires signed fetch.