Fix video thumbnail generation (fixes #3484) #4539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
requested review from
dessalines,
phiresky and
dullbananas
as code owners
Nutomic
commented
Mar 15, 2024
| generate_thumbnail: bool, | ||
| context: &LemmyContext, | ||
| ) -> Option<DbUrl> { | ||
| let is_image = content_type.as_ref().unwrap_or(&mime::TEXT_PLAIN).type_() == mime::IMAGE; | ||
| if generate_thumbnail && is_image { |
There was a problem hiding this comment.
This was actually checking the thumbnail of the post.url, ie a youtube.com url. So this would give is_image = false even for a valid opengraph thumbnail.
Nutomic
commented
Mar 15, 2024
| .unwrap_or(url); | ||
| generate_pictrs_thumbnail(image_url, context) | ||
| .await | ||
| .ok() | ||
| .map(Into::into) | ||
| } else { | ||
| None | ||
| opengraph_data.image.clone() |
There was a problem hiding this comment.
We can simply hotlink the thumbnail from the original website in this case.
dessalines
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into the linked issue I noticed a few issues with thumbnail generation. I probably introduced them while implementing the image proxying.