Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate apub block activity to standard endTime property and deprecate expires (fixes #2316) #4541

Merged
merged 2 commits into from Mar 25, 2024

Conversation

Nutomic
Copy link
Member

@Nutomic Nutomic commented Mar 15, 2024

No description provided.

@dullbananas dullbananas changed the title Migrate apub block activity to standard endTime property (fixes #2316) Migrate apub block activity to standard endTime property and deprecate expires (fixes #2316) Mar 16, 2024
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge after comment below.

@@ -38,7 +38,9 @@ pub struct BlockUser {
pub(crate) remove_data: Option<bool>,
/// block reason, written to mod log
pub(crate) summary: Option<String>,
/// deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a TODO line here, or maybe create another issue to keep track of this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added todo.

@Nutomic Nutomic enabled auto-merge (squash) March 25, 2024 11:30
@Nutomic Nutomic merged commit d06ef2c into main Mar 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants