When uploading new avatar/banner, delete old one #4548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
requested review from
dessalines,
phiresky and
dullbananas
as code owners
Nutomic
commented
Mar 18, 2024
Nutomic
commented
Mar 18, 2024
|
Updated, it now also deletes old site and community icons/banners when a new one is uploaded. |
Nutomic
force-pushed
the
delete-old-avatar
branch
from
caaee7e
to
8414b58
Compare
dessalines
approved these changes
Mar 26, 2024
|
This maybe was wrongly closed cause that branch got merged and deleted. @Nutomic you might need to re-open this up, but pointing at |
|
Shit, This was not what I meant to close. |
|
No worries it was only deleted because the delete_images branch was deleted. I have no clue why the PR pointed at that and not main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently keep old avatars, banners etc around forever. It makes sense to delete them when a new one is uploaded. For now I implemented it only for user avatar change, but will do the same for user banner, community icon etc if it looks good.
Depends on #4509