Add banned_from_community to PostView and CommentView #4552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SleeplessOne1917
requested review from
Nutomic,
dessalines,
phiresky and
dullbananas
as code owners
dullbananas
previously approved these changes
Mar 19, 2024
|
Please add some test coverage, either via unit tests or api_tests. Its probably enough to add some extra asserts in existing tests rather than writing a new one. |
| @@ -77,7 +77,7 @@ impl CustomEmojiView { | |||
| } | |||
| for emoji in &mut result { | |||
| if let Some(keywords) = hash.get_mut(&emoji.custom_emoji.id) { | |||
| emoji.keywords = keywords.clone(); | |||
| emoji.keywords.clone_from(keywords); | |||
There was a problem hiding this comment.
scripts/lint.sh did this.
Nutomic
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #4458.
I went to try to implement this for the frontend after #4458 and found that even with
banned_from_communityon theCommunityView, trying to use this information at best requires a lot of prop drilling and at worst (when viewing posts/comments outside of the context of a community) requires the convoluted approaches I listed in #4458.