updates.py: cleanup pass #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mglae can you have a look |
antonlacon
force-pushed
the
update-base
branch
2 times, most recently
from
9899c7b
to
27cecd3
Compare
antonlacon
force-pushed
the
update-base
branch
2 times, most recently
from
c1976da
to
c7940e2
Compare
antonlacon
force-pushed
the
update-base
branch
from
c7940e2
to
6603e8f
Compare
antonlacon
force-pushed
the
update-base
branch
2 times, most recently
from
e199155
to
d70b134
Compare
General review and cleanup of issues pointed out by pylint: unexpected indent could use f-strings not inializing variables in init redefining builtins too broad exceptions unneeded elses after returns unneeded parantheses == instead of is in evaluating True/False unused function parameters unused imports Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Addon will require Python >=3.9 Signed-off-by: Ian Leonard <antonlacon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup pass on updates.py. Some issues from reviewing it and some issues shown by pylint. Functional changes are converting Automatic Updates from a auto/manual selector to true/false and deleting custom channel 3. Info text for automatic updates also updated to reflect change.
The lchop/rchop changes means >=python-3.9, so no more support for LE10.
It's pulled the RPi2 LE11.0.0 -> 11.0.1 update for me. Other device testing appreciated.