Format cleanup #66
Format cleanup #66
Conversation
| @@ -10,7 +10,7 @@ sudo apt-get install -y -qq cmake \ | |||
| qt6-l10n-tools \ | |||
| qt6-tools-dev \ | |||
| qt6-tools-dev-tools \ | |||
| qt6-wayland-dev \ | |||
| qt6-wayland-dev | |||
There was a problem hiding this comment.
I added the backslash intentionally :)
There was a problem hiding this comment.
what does this achieve ? from bash perspective its just adding a useless space character at the end of the command
There was a problem hiding this comment.
if you add another line (package) below this one in the future, you won't have to modify this line. JSON format from such issue for example - you can't add comma after last element in object/array.
| version: "6.6.2" | ||
| arch: "win64_msvc2019_64" | ||
| archives: "qtbase qttools opengl32sw d3dcompiler_47" | ||
| extra: "--external 7z" |
There was a problem hiding this comment.
I guess quotes can be omitted completely
There was a problem hiding this comment.
yes/no, it will likely work without quotes too but in general quotes are wanted - also shown at the official GHA examples etc so won't hurt doing proper gha/yml
There was a problem hiding this comment.
well, we don't use them in other places. Either they should be used everywhere or nowhere at all.
| @@ -4,58 +4,66 @@ This is a lightweight image writing app with a simple four-step GUI for creating | |||
|
|
|||
| ## Translation Changes | |||
|
|
|||
| Changes to master language (en_GB) strings can be submitted via pull request to this GitHub repo. English strings are periodically synchronised to a Transifex project: https://www.transifex.com/libreelec/libreelec-usb-sd-creator allowing contributors to translate them into other languages. Translated strings are periodically synchronised from Transifex back to this repo for inclusion in the next release. | |||
| Changes to master language (en_GB) strings can be submitted via pull request to this GitHub repo. English strings are periodically synchronised to a Transifex project: <https://www.transifex.com/libreelec/libreelec-usb-sd-creator> allowing contributors to translate them into other languages. Translated strings are periodically synchronised from Transifex back to this repo for inclusion in the next release. | |||
There was a problem hiding this comment.
better place link on text
There was a problem hiding this comment.
<http...> is valid markdown for just links, current formatting is not
There was a problem hiding this comment.
I mean, link embedded in text would be more readable in this case
FYI for GFMD angle brackets aren't needed: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/autolinked-references-and-urls#urls
|
|
||
| Please note: languages are translated by people (you) not magic! | ||
|
|
||
| ## Issues and Support | ||
|
|
||
| Issues should be reported via the forum here: https://forum.libreelec.tv/board/41-usb-sd-creator-support | ||
| Issues should be reported via the forum here: <https://forum.libreelec.tv/board/41-usb-sd-creator-support> |
There was a problem hiding this comment.
not clear why the angle brackets are needed
|
in CMakeLists your formatter actually did the right thing with this line, and it seems you simply dropped all changes to CMakeLists :) https://github.com/LibreELEC/usb-sd-creator/blob/master/CMakeLists.txt#L11 |
Some basic format fixes done by automatic code formatting.
I have intentionally left out the real coding stuff, there are A LOT changes I can not really valuate if they are okay or not.
Likewise nobody ever used a code formatter at that codebase :)
3ae8cc1 prevents verbose logspam at the ci from apt