Fixed: Trim all leading dots from nested folders (#2371) #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -131,7 +131,7 @@ public string BuildTrackFileName(List<Track> tracks, Artist artist, Album album, | |||
|
|
|||
| var component = ReplaceTokens(splitPattern, tokenHandlers, namingConfig).Trim(); | |||
|
|
|||
| component = FileNameCleanupRegex.Replace(component, match => match.Captures[0].Value[0].ToString()); | |||
There was a problem hiding this comment.
Rather than this change, would it be better to modify the 'CleanFolderName' method to trim leading "." characters? Then if a user would like to keep the leading "." they can use {Album Title}, but trimming is available with {Album CleanTitle} or any of the other 'clean' tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
Remove leading ellipses/dots from nested folder names so that they are not hidden.
Screenshot (if UI related)
Todos
Issues Fixed or Closed by this PR